AuthorListParser broken for "and others"

[koppor]

@TechReport{Ao2019TR,
  title  = {The Industrial Reference Architecture ({iRefA}) -- Description and User Guidance for System Architects},
  editor = {Alexander Artemenko and others},
  year   = {2019},
}

Why is Ao2019TR generated as BibTeX key and not Artmenko? The AuthorListParser is broken!

[Siedlerchr]

What's your citaiton key pattern?

[Siedlerchr]

Default [auth][year] pattern generates:

@TechReport{Artemenko2019,
  title  = {The Industrial Reference Architecture ({iRefA}) -- Description and User Guidance for System Architects},
  editor = {Alexander Artemenko and others},
  year   = {2019},
}

[k3KAW8Pnf7mkmdSMPHz27]

It could be the heuristics for companies/entities/organizations as well. It might get triggered (because only one name) and dislike the capitalization

[morganteg]

Hi, I'd like to contribute to fix the issue. I already have a fix idea that already make the AuthorListParserTest.java to be executed successfully. I only would to ask which Test Case should I execute in order to verify that the correct citation is generated:

@TechReport{Artemenko2019,
  title  = {The Industrial Reference Architecture ({iRefA}) -- Description and User Guidance for System Architects},
  editor = {Alexander Artemenko and others},
  year   = {2019},
}

Thanks, regards.

[Siedlerchr]

@morganteg That sounds great! I hope I understood you right, I think it should be sufficient to add a test case to CitationKeyGeneratorTest in addition to the AuthorListParserTest

[morganteg]

Yes, many thanks! I added the following test that should correctly test the issue:

@Test
void generateKeyCorrectKeyWithAndOthersAtTheEnd() {
    BibEntry entry = createABibEntryAuthor("Alexander Artemenko and others");
    entry.setField(StandardField.YEAR, "2019");
    assertEquals("Artemenko2019", generateKey(entry, "[auth][year]"));
}

If you agree, I will create a Pull Request with my changes.

Regards.

[Siedlerchr]

Yes that looks good! Go ahead!

[koppor]

Citation Key generator is probably authorsAlpha. All keys are listed at https://docs.jabref.org/setup/citationkeypatterns#special-field-markers. Test class is /src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java#L27.