Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 port #524

Closed
wants to merge 2 commits into from
Closed

Python 3 port #524

wants to merge 2 commits into from

Conversation

Salamandar
Copy link

@Salamandar Salamandar commented Aug 28, 2019

There are still bugs, but this project needed a Python 3 port. That's starting now I guess.

I had to port to spaces because Python was complaining about mixed spaces and tabs. And spaces are considered as the preferred tabulation system in Py3.

@phw
Copy link

phw commented Oct 2, 2019

Just for reference, PR #475 was a previous attempt at this. I haven't compared, but it might be worth looking there and taking things that probably are missing in this PR.

Relevant issue is #487

@Salamandar
Copy link
Author

I think you will have to make a "python3" branch where all our PR will be merged, so that it doesn't need a single big PR.

@dralley
Copy link
Contributor

dralley commented Oct 2, 2019

Feel free to reuse my work in the aforementioned PR, I don't mind. I tried to keep each individual change in it's own commit.

I would however suggest not changing all of the tabs to spaces, because it will make the PR impossible to review. It's probably only a couple of places that are mixing improperly.

If @kozec will allow it, a separate PR to convert tabs to spaces would be good, though.

Source on the Python language officially preferring spaces over tabs: https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

@st-review
Copy link

🤖 beep boop

I'm going to close this pull request as it has been idle for more than 90 days.

This is not a rejection, merely a removal from the list of active pull requests that is periodically reviewed by humans. The pull request can be reopened when there is new activity, and merged once any remaining issues are resolved.

@st-review st-review closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants