Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consumer committed metrics should use committed and not last_sta… #120

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

marcosschroh
Copy link
Collaborator

…ble_offset

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #120 (84beb8b) into master (f8f3158) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   94.31%   94.32%   +0.01%     
==========================================
  Files          20       20              
  Lines         703      705       +2     
==========================================
+ Hits          663      665       +2     
  Misses         40       40              
Flag Coverage Δ
unittests 94.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kstreams/prometheus/monitor.py 100.00% <100.00%> (ø)
kstreams/test_utils/test_clients.py 84.15% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

@marcosschroh marcosschroh merged commit cf3d897 into kpn:master Jul 20, 2023
6 of 7 checks passed
@marcosschroh marcosschroh deleted the fix/consumer-committed-metric branch July 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants