fix: Prometheus scrape metrics task fixed in order to have a proper s… #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hutdown The monitor shutdown will wait until the scraping Task is done rather than canceling it. Parameter metrics_scrape_time added.
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 94.06% 94.10% +0.03%
==========================================
Files 20 20
Lines 708 712 +4
==========================================
+ Hits 666 670 +4
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
woile
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hutdown
The monitor shutdown will wait until the scraping Task is done rather than canceling it. Parameter metrics_scrape_time added.