Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to feature/apollo-pure #1714

Merged

Conversation

piglovesyou
Copy link
Collaborator

@piglovesyou piglovesyou commented Feb 18, 2019

I added Apollo features.

  • Codegen Flow types through GraphQL Introspection
  • GraphQL Timestamp scalar type

1. ncu --upgradeAll
4. Leave "graphql" to be "^13.2.0" that apollo packages depend on
2. Apply patch of "npx babel-upgrade" output
3. Leave only necessary babel plugins
4. Pass "yarn fix" by disabling stricter rules
* Through rootValue it cannot be passed from browser GraphQL access
* rm unnecessary code
* npm graphql requires to be update
vercel/next.js#5238 (comment)
* install apllo

* add apollo.config.js

* apollo codegen succeeded

* fix: updateNetworkStatus signature

* rm @flow from files not ready

* add flow-typed files

* done: Using auto-generated types works

* flow-bin@0.89+ has regression. Use ^0.88.0.

* fix: invalid GraphQL primitive types

* Add codegen script

* done: import auto-generated file

* refac: move impl for apollo-link-state to graphql dir as same as server side resolvers

* codegen and ignore eslint these files

* refactor: "networkStatus"

* feat: codegen:standalone
* delete existing auto-generated types

* change script name

* ignore __generated__ folder

* wip: disallow absolute path resolving under `src` dir

* It causes disregard .js type checking under src

* fix all flow error

* modify: prevent `withStyles` drops component type
* Fix build failure: Codegen before lint

* Add Node v10 LTS for build target
@piglovesyou
Copy link
Collaborator Author

@langpavel I enhanced Apollo integration. Glad if you take a look.

@langpavel langpavel merged commit 12760a0 into kriasoft:feature/apollo-pure Feb 19, 2019
@piglovesyou
Copy link
Collaborator Author

Thank you!

@langpavel
Copy link
Collaborator

langpavel commented Feb 19, 2019

I thak you! But sorry, I must squash commits,
other merge methods are not allowed from GitHub UI for this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants