feat: space sort & categorization #1323
Open
+568
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, for design changes please first create a feature issue with low level mock-ups, then high level mock-ups and let them be approved. Otherwise you are at risk that the PR does not get accepted |
|
What are low-level and high-level mock-ups? Are there any example issues I can refer to? Sorry I'm just really unfamiliar with this. |
|
I tried to make one here: #1326 |
everypizza1
reviewed
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Please make sure that your Pull Request meet the following acceptance criteria:
dart format lib/ test/anddart run import_sorter:main --no-commentsEvery new feature or change of the design/GUI is linked to an approved design proposal in an issueNo one answered my issue (Feat: categorize subspace #1155 / feat: Room Order & Subspace Categorization #1326) so I just made this on my ownEvery new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainershipI have never programmed in Dart/Flutter prior to this so I have absolutely no ideaPull Request has been tested on:
Screenshot
Additional notes
I REALLY wanted an Android Matrix client with specifically the categorization feature, but I couldn't figure out how to build an APK, so if someone can help it would be awesome.