Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nginx to one that doesn't need root #924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Mar 4, 2024

I prefer running unprivledged containers whenever possible. It seems like an easy win to run as non root.

That being said, if it works, it would be a breaking change since its port 8080 not 80 now

@halkeye
Copy link
Contributor Author

halkeye commented Mar 4, 2024

@halkeye halkeye marked this pull request as ready for review March 4, 2024 07:45
@krille-chan
Copy link
Owner

I don't know if all consumers of the docker image prefer this 🤔 so no idea what to do with it. Can you maybe host this by yourself?

@krille-chan krille-chan added the stale The item is going to be closed soon because of inactivity label Apr 10, 2024
@halkeye
Copy link
Contributor Author

halkeye commented Apr 10, 2024

Yea I can't say either. I generally think rootless docker images are good practice.

I believe I have a docker image created whenever a new release happens, so I'm not desperate, but being lazy it's nicer upstream :)

@github-actions github-actions bot removed the stale The item is going to be closed soon because of inactivity label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants