forked from thanos-io/thanos
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
query: introduce dynamic lookback interval
Closes thanos-io#2608 This allows queries with large step to make use of downsampled data. Signed-off-by: Vladimir Kononov <krya-kryak@users.noreply.github.com>
- Loading branch information
1 parent
bb1662a
commit 75de5c9
Showing
5 changed files
with
201 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
package main | ||
|
||
import ( | ||
"testing" | ||
"time" | ||
|
||
"github.com/prometheus/prometheus/promql" | ||
|
||
"github.com/thanos-io/thanos/pkg/testutil" | ||
) | ||
|
||
func TestEngineFunc(t *testing.T) { | ||
var ( | ||
engineDefault = promql.NewEngine(promql.EngineOpts{LookbackDelta: 123}) | ||
engine5m = promql.NewEngine(promql.EngineOpts{LookbackDelta: 5 * time.Minute}) | ||
engine1h = promql.NewEngine(promql.EngineOpts{LookbackDelta: 1 * time.Hour}) | ||
) | ||
fakeNewEngine := func(lookback time.Duration) *promql.Engine { | ||
switch lookback { | ||
case 1 * time.Hour: | ||
return engine1h | ||
case 5 * time.Minute: | ||
return engine5m | ||
default: | ||
return engineDefault | ||
} | ||
} | ||
type testCase struct { | ||
stepMillis int64 | ||
expect *promql.Engine | ||
} | ||
var ( | ||
minute = time.Minute.Milliseconds() | ||
hour = time.Hour.Milliseconds() | ||
tData = []struct { | ||
lookbackDelta time.Duration | ||
dynamicLookbackDelta bool | ||
tcs []testCase | ||
}{ | ||
{ | ||
// Non-dynamic lookbackDelta should always return the same engine. | ||
lookbackDelta: 0, | ||
dynamicLookbackDelta: false, | ||
tcs: []testCase{ | ||
{0, engineDefault}, | ||
{5 * minute, engineDefault}, | ||
{1 * hour, engineDefault}, | ||
}, | ||
}, | ||
{ | ||
lookbackDelta: 3 * time.Minute, | ||
dynamicLookbackDelta: true, | ||
tcs: []testCase{ | ||
{2 * minute, engineDefault}, | ||
{3 * minute, engineDefault}, | ||
{4 * minute, engine5m}, | ||
{5 * minute, engine5m}, | ||
{6 * minute, engine1h}, | ||
{1 * hour, engine1h}, | ||
{2 * hour, engine1h}, | ||
}, | ||
}, | ||
{ | ||
lookbackDelta: 5 * time.Minute, | ||
dynamicLookbackDelta: true, | ||
tcs: []testCase{ | ||
{0, engine5m}, | ||
{5 * minute, engine5m}, | ||
{6 * minute, engine1h}, | ||
{59 * minute, engine1h}, | ||
{1 * hour, engine1h}, | ||
{2 * hour, engine1h}, | ||
}, | ||
}, | ||
{ | ||
lookbackDelta: 30 * time.Minute, | ||
dynamicLookbackDelta: true, | ||
tcs: []testCase{ | ||
{0, engineDefault}, | ||
{5 * minute, engineDefault}, | ||
{30 * minute, engineDefault}, | ||
{31 * minute, engine1h}, | ||
{59 * minute, engine1h}, | ||
{1 * hour, engine1h}, | ||
{2 * hour, engine1h}, | ||
}, | ||
}, | ||
{ | ||
lookbackDelta: 1 * time.Hour, | ||
dynamicLookbackDelta: true, | ||
tcs: []testCase{ | ||
{0, engine1h}, | ||
{5 * minute, engine1h}, | ||
{1 * hour, engine1h}, | ||
{2 * hour, engine1h}, | ||
}, | ||
}, | ||
} | ||
) | ||
for _, td := range tData { | ||
e := engineFunc(fakeNewEngine, td.lookbackDelta, td.dynamicLookbackDelta) | ||
for _, tc := range td.tcs { | ||
got := e(tc.stepMillis) | ||
testutil.Equals(t, tc.expect, got) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters