Fix spurious creation of '=' file #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is quoted from Marcin Cieślak [*]: When running under FreeBSD /bin/sh (and not ksh) we get spurious file named '=' created in the root. This is because the "checksh" function runs /bin/sh -c '(( .sh.version >= 20111111 ))' which produces a "=" file with /bin/sh as a side effect. This bug was reported in ksh93#13, but was closed in error. I was still getting the "=" file to generate on FreeBSD. bin/package, src/cmd/INIT/package.sh: - Fix the creation of a spurious '=' file by making sure the shell has support for (( ... )) expressions. .gitignore: - Remove the '=' file entry since it no longer has a purpose. [*]: https://bsd.network/@saper/103196289917156347
JohnoKing
force-pushed
the
remove-spurious-equals
branch
from
4d0de96
to
a3a017d
Compare
McDutchie
reviewed
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system on certain platforms will create a spurious '=' file in the repository's root directory due to an incorrect assumption the
checkshfunction makes about the shell. The following is quoted from @saper:The bugfix simply makes sure the shell supports (( ... )) expressions before attempting to check
${.sh.version}. This bug was reported in #13, but that issue was closed in error. I was still getting an "=" file to generate on FreeBSD.References:
att#963 (comment)
https://bsd.network/@saper/103196289917156347
https://repo.or.cz/INIT.git