Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ActiveSupport dependency #141

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Remove ActiveSupport dependency #141

merged 2 commits into from
Jun 21, 2017

Conversation

jlduran
Copy link
Collaborator

@jlduran jlduran commented Jun 20, 2017

This commit removes the dependency on the ActiveSupport gem by doing the following:

  • Replace constantize with Object.const_get()
  • Remove the following Object methods:
    • blank?
    • present?
  • Remove the following String methods:
    • camelcase
    • titleize
    • underscore

Closes #106

@jlduran
Remove ActiveSupport dependency
c81d1d5 
This commit removes the dependency on the `ActiveSupport` gem by doing
the following:

- Replace `constantize` with `Object.const_get()`
- Remove the following `Object` methods:
    - `blank?`
    - `present?`
- Remove the following `String` methods:
    - `camelcase`
    - `titleize`
    - `underscore`

Closes kslazarev#106
Repository owner deleted a comment from coveralls Jun 20, 2017
@coveralls
Copy link

coveralls commented Jun 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 99.42% when pulling c81d1d5 on jlduran:no-activesupport into 4235411 on kslazarev:master.

dblock
dblock requested changes Jun 20, 2017
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. You still need to re-generate a .gemspec without the AS dependency.
Or maybe rewrite .gemspec by hand and remove Jeweler too?

@jlduran
Copy link
Collaborator Author

jlduran commented Jun 20, 2017

Yes, I plan on releasing the gem over the weekend if there are no issues.

I'll try to remove Jeweler as well, as you propose, although I would prefer to do it in a separate commit. Thank you!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 99.894% when pulling f6198a2 on jlduran:no-activesupport into 4235411 on kslazarev:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 99.894% when pulling f6198a2 on jlduran:no-activesupport into 4235411 on kslazarev:master.

@coveralls
Copy link

coveralls commented Jun 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 99.42% when pulling f6198a2 on jlduran:no-activesupport into 4235411 on kslazarev:master.

@dblock dblock merged commit e7433c4 into kslazarev:master Jun 21, 2017
@dblock
Copy link
Collaborator

dblock commented Jun 21, 2017

Merged, looks great.

@jlduran jlduran deleted the no-activesupport branch June 21, 2017 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Assignees
No one assigned
Labels
discuss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlduran @coveralls @dblock