Fix unit tests and add CI jobs #467
Conversation
|
Strange. Locally (on |
|
It seems that it is not a trivial task to run |
bamx23
force-pushed
the
fix-tests-crashing
branch
2 times, most recently
from
9dfa6b9
to
19f0f0e
Compare
There was a problem hiding this comment.
Great!
Just update the xcodebuild action to the latest version and we're good to go.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mxcl/xcodebuild@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
| config: '' | ||
| config: "" | ||
| - platform: iOS | ||
| config: '--use-libraries' | ||
| config: "--use-libraries" | ||
| - platform: iOS | ||
| config: '--use-libraries --use-modular-headers' | ||
| config: "--use-libraries --use-modular-headers" | ||
| - platform: iOS | ||
| config: '--use-static-frameworks' | ||
| config: "--use-static-frameworks" | ||
| - platform: macOS | ||
| config: '' | ||
| config: "" | ||
| - platform: tvOS | ||
| config: '' | ||
| config: "" | ||
| - platform: watchOS | ||
| config: '' | ||
| config: "" |
There was a problem hiding this comment.
@GLinnik21 FYI: These changes are generated by VSCode auto-format-on-save. Hope you don't mind
There was a problem hiding this comment.
Ok, it seems the problem persists in the version 2 of xcodebuild action as well.
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mxcl/xcodebuild@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Had to make a fork and fixed version of Node there: mxcl/xcodebuild#103. Once PR is accepted we can switch back to upstream. |
This PR quickly fixes unit tests as a whole by disabling the parts that are broken. It's better to keep running the remaining working tests then not running them at all.