Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SIGTERM #472

Merged

Conversation

naftaly
Copy link
Contributor

@naftaly naftaly commented May 7, 2024

As in getsentry/sentry-cocoa#3895 and firebase/firebase-ios-sdk#12881, this adds support for the SIGTERM signal which Apple often uses before sending SIGKILL.

@GLinnik21 GLinnik21 requested review from bamx23 and GLinnik21 May 7, 2024 19:57
Copy link
Collaborator

@GLinnik21 GLinnik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the support for SIGTERM signal being added, thanks for this! We're currently focusing on the release-2.0 branch, and since this change isn't critical for version 1, could you please base your changes on release-2.0 instead? Would appreciate your help with this shift!

@naftaly naftaly changed the base branch from master to release-2.0 May 7, 2024 20:53
@naftaly naftaly force-pushed the Graceful-Termination-Support branch from 7cb393a to 8217d6b Compare May 7, 2024 21:03
@naftaly naftaly requested a review from GLinnik21 May 7, 2024 21:05
Source/KSCrash-Tests/KSCrashDoctor_Tests.m Outdated Show resolved Hide resolved
Source/KSCrash-Tests/KSCrashDoctor_Tests.m Outdated Show resolved Hide resolved
@naftaly naftaly requested a review from GLinnik21 May 9, 2024 16:45
Used for sharing the defines for SWIFTPM_MODULE_BUNDLE.
@naftaly naftaly requested a review from GLinnik21 May 9, 2024 21:59
@GLinnik21 GLinnik21 merged commit 61e396d into kstenerud:release-2.0 May 9, 2024
14 checks passed
@naftaly naftaly deleted the Graceful-Termination-Support branch May 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants