Run tests on different OS versions #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamx23
force-pushed
the
os-version-tests
branch
12 times, most recently
from
d73e7f3
to
d00553c
Compare
GLinnik21
approved these changes
May 12, 2024
| @@ -31,14 +31,34 @@ | |||
|
|
|||
| #include <mach/mach.h> | |||
| #include <mach-o/arch.h> | |||
|
|
|||
| #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 160000 // Xcode 14 | |||
There was a problem hiding this comment.
Maybe #if __has_include(<mach-o/utils.h>) here or this header may not have the necessary functions in older versions of the SDK?
There was a problem hiding this comment.
While effectively I indeed need to check for this file, I think it's better to just have this Xcode version check (where these functions were added)
GLinnik21
requested changes
May 13, 2024
Open
11 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on try for running tests on different OS versions from #470