Run clang-format in GitHub Actions #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
force-pushed
the
clang-format
branch
2 times, most recently
from
972a46e
to
a14718c
Compare
bamx23
reviewed
Jun 26, 2024
Sources/KSCrashRecording/Monitors/KSCrashMonitor_MachException.c
Outdated
Show resolved
Hide resolved
bamx23
reviewed
Jun 27, 2024
bamx23
reviewed
Jun 27, 2024
GLinnik21
force-pushed
the
clang-format
branch
6 times, most recently
from
0953264
to
640f09b
Compare
|
Also, to keep git-blame clean, I think we should do this |
Yes, definitely. Didn't know about this |
bamx23
reviewed
Jun 28, 2024
.github/workflows/clang-format.yml
Outdated
| sudo apt-get install -y clang-format-18 | ||
|
|
||
| - name: Define directories | ||
| run: echo "DIRS='Sources Tests Samples/Common/Sources/CrashTriggers' " >> $GITHUB_ENV |
There was a problem hiding this comment.
I remember that it's poossible to specify env for a job here in the spec and not in runtime
.github/workflows/clang-format.yml
Outdated
| - name: Check formatting | ||
| run: | | ||
| find $DIRS -name '*.c' -o -name '*.cpp' -o -name '*.h' -o -name '*.m' | \ | ||
| xargs -r clang-format-18 -style=file -n -Werror |
There was a problem hiding this comment.
By the way, maybe it's better to add back a Makefile with this? Or a script. As otherwise it might not be easy for contributors to fix formatting without applying the patch from PR (I would prefer to fix format before I submit changes)
There was a problem hiding this comment.
Let's do it in another PR
.github/workflows/clang-format.yml
Outdated
| - name: Suggest formatting fixes | ||
| if: failure() | ||
| run: | | ||
| echo "Formatting issues found. Please run clang-format-18 on your code." |
There was a problem hiding this comment.
GLinnik21
force-pushed
the
clang-format
branch
11 times, most recently
from
7b6d6d1
to
44fb0a9
Compare
Add `.clang-format-ignore` Use LLVM in format Populate `.clang-format-ignore` add `Samples/Common/Sources/CrashTriggers` to trigggers Add subdirectories in ignore Run only for trigger paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.