Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes constroctors of
KSCrash
class, but allows setting a custom base path via a helper static method.As there are cases when shared instance of
KSCrash
is used from inside of the library code we need to make sure that base path is consistent.Also, in general,
KSCrash
is intended to be a singletone as the most of C API under the hood operates with global state. Multiple instances of KSCrash was never supported.