Use typed crash reports #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
reviewed
Jun 24, 2024
bamx23
commented
Jun 25, 2024
| @@ -37,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| * user cancelling the operation). | |||
| * @param error Non-nil if an error occurred. | |||
| */ | |||
| typedef void(^KSCrashReportFilterCompletion)(NSArray<NSDictionary<NSString *,id> *>* _Nullable filteredReports, | |||
| typedef void(^KSCrashReportFilterCompletion)(NSArray<KSCrashReport*>* _Nullable filteredReports, | |||
There was a problem hiding this comment.
The key issue was here. This callback would crash if implemented with Swift and the value type is not a dictionary.
GLinnik21
approved these changes
Jun 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filters API was using dictionary in definitions but actually the report there can become a string or a data.
There's no nice way to implement union type or enum with associated values in ObjC. So this is a kind of workaround.