Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ObjC categories #520

Merged
merged 12 commits into from
Jun 30, 2024
Merged

Remove ObjC categories #520

merged 12 commits into from
Jun 30, 2024

Conversation

bamx23
Copy link
Collaborator

@bamx23 bamx23 commented Jun 29, 2024

There were several ObjC categories that weren't critical for the code but required linker ObjC flag (not really, but there was a hack to make it work).

Bye! Farewell!

@bamx23 bamx23 requested a review from GLinnik21 June 29, 2024 17:04
Copy link
Collaborator

@GLinnik21 GLinnik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have removed all extensions, we no longer need the -ObjC flag in the compiler flags. Please consider removing this statement from the README.

@bamx23 bamx23 merged commit ae4d75c into master Jun 30, 2024
26 checks passed
@bamx23 bamx23 deleted the remove-categories branch June 30, 2024 16:54
@bamx23
Copy link
Collaborator Author

bamx23 commented Jun 30, 2024

Haven't found any -ObjC reference in the repo, by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants