Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Unsigned Integer Elements, Enhance JSON Encoding/Decoding Robustness, and Replace sprintf with Safer snprintf #526

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

GLinnik21
Copy link
Collaborator

This update adds support for handling and accurately encoding/decoding unsigned integer elements in JSON, ensures compatibility with large values, replaces sprintf with the safer snprintf function, and extends the test suite to cover edge cases for integers, unsigned integers, and floating point numbers.
However, it does not address the suboptimal implementation where a single function handles both float and double types, which ideally need separate functions for better precision and clarity.

@GLinnik21 GLinnik21 requested a review from bamx23 July 6, 2024 00:26
@GLinnik21 GLinnik21 linked an issue Jul 6, 2024 that may be closed by this pull request
Sources/KSCrashRecordingCore/KSJSONCodec.c Outdated Show resolved Hide resolved
@GLinnik21 GLinnik21 merged commit 8137c49 into master Jul 7, 2024
26 checks passed
@GLinnik21 GLinnik21 deleted the fix-sprintf branch July 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace sprintf with snprintf
2 participants