Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KSCrash installation error handling and reporting #531

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

GLinnik21
Copy link
Collaborator

@GLinnik21 GLinnik21 commented Jul 12, 2024

This PR improves the KSCrash installation process by introducing detailed error handling and updating the installation method to return specific error codes. It also updates the SampleView to display alerts for installation failures and refactors relevant methods and tests to support these changes.

@GLinnik21 GLinnik21 linked an issue Jul 12, 2024 that may be closed by this pull request
@GLinnik21 GLinnik21 marked this pull request as ready for review July 13, 2024 01:29
@GLinnik21 GLinnik21 requested a review from bamx23 July 13, 2024 01:29
@GLinnik21 GLinnik21 requested a review from bamx23 July 14, 2024 23:04
Sources/KSCrashRecording/KSCrash.m Outdated Show resolved Hide resolved
@GLinnik21 GLinnik21 merged commit 3e3d393 into master Jul 15, 2024
26 checks passed
@GLinnik21 GLinnik21 deleted the fix-install-error branch July 15, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installWithConfiguration always returns true
2 participants