Add integration tests #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamx23
force-pushed
the
integration-tests
branch
from
2b57680
to
631134e
Compare
GLinnik21
reviewed
Aug 3, 2024
|
It seems that it fails on watchOS because there is no |
|
Wow, exporting |
GLinnik21
approved these changes
Aug 11, 2024
| } | ||
|
|
||
| func readRawCrashReportData() throws -> Data { | ||
| enum Error: Swift.Error { |
There was a problem hiding this comment.
Just asking. Is it OK to use Error which can be ambiguous in some cases? Also, maybe it would be more useful to define one Error enum for the whole TestCase?
There was a problem hiding this comment.
Well, these are only valid inside tests and not expected to be used as API. Made it a bit more clear but not sure if we need a single common enum
GLinnik21
reviewed
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a foundation for integration tests