Extract report store API #549
Conversation
| * | ||
| * @param onCompletion Called when sending is complete (nil = ignore). | ||
| */ | ||
| - (void)sendAllReportsWithCompletion:(nullable KSCrashReportFilterCompletion)onCompletion; |
There was a problem hiding this comment.
In swift it looks like open func sendAllReports() async throws -> ([any KSCrashReport], Bool). Perhaps it would be useful to document the "return value" as well?
There was a problem hiding this comment.
Don't think it's a right way... Tried playing with the docs but wasn't happy with the results. We can iterate on this later, it's good that API itself looks fine. Maybe we can drop "isSuccess" and assume that "no error == success". This would make API more clean.
There was a problem hiding this comment.
Maybe we can drop "isSuccess" and assume that "no error == success". This would make API more clean.
Yeah, I like this approach
There was a problem hiding this comment.
Will do separately, it would bring way too many changes to this PR
There is a set of methods in KSCrash API that expect install or report store setup.
But we don't actually need any global state to work with crash reports. So this PR adds a separate reports store class that extracts all public API for reports reading.