Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better logging for watcher errors #1134

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add better logging for watcher errors #1134

merged 2 commits into from
Feb 6, 2023

Conversation

clux
Copy link
Member

@clux clux commented Feb 2, 2023

For #1132

trying to hunt a potential bug

Signed-off-by: clux <sszynrae@gmail.com>

better tracing

Signed-off-by: clux <sszynrae@gmail.com>

ugh

Signed-off-by: clux <sszynrae@gmail.com>

lesssss output

Signed-off-by: clux <sszynrae@gmail.com>

remove backoff reset

Signed-off-by: clux <sszynrae@gmail.com>

better errors for watcher

Signed-off-by: clux <sszynrae@gmail.com>

re-add line

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-fix changelog fix category for prs label Feb 2, 2023
@clux clux added this to the 0.79.0 milestone Feb 2, 2023
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review February 2, 2023 14:42
@codecov-commenter
Copy link

Codecov Report

Merging #1134 (1badea6) into main (1f5cc0a) will decrease coverage by 0.21%.
The diff coverage is 12.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   72.69%   72.48%   -0.21%     
==========================================
  Files          65       65              
  Lines        4882     4896      +14     
==========================================
  Hits         3549     3549              
- Misses       1333     1347      +14     
Impacted Files Coverage Δ
kube-client/src/lib.rs 94.00% <ø> (ø)
kube-core/src/crd.rs 82.92% <ø> (ø)
kube-runtime/src/watcher.rs 43.61% <0.00%> (-7.64%) ⬇️
kube-client/src/config/file_loader.rs 85.41% <100.00%> (ø)

@clux clux linked an issue Feb 2, 2023 that may be closed by this pull request
@clux clux requested a review from nightkr February 6, 2023 07:26
@clux clux merged commit 4c26615 into main Feb 6, 2023
@clux clux deleted the self-reconcile-debug branch February 6, 2023 09:46
danrspencer pushed a commit to danrspencer/kube-rs that referenced this pull request Feb 16, 2023
* tracing output from kube-runtime

trying to hunt a potential bug

Signed-off-by: clux <sszynrae@gmail.com>

better tracing

Signed-off-by: clux <sszynrae@gmail.com>

ugh

Signed-off-by: clux <sszynrae@gmail.com>

lesssss output

Signed-off-by: clux <sszynrae@gmail.com>

remove backoff reset

Signed-off-by: clux <sszynrae@gmail.com>

better errors for watcher

Signed-off-by: clux <sszynrae@gmail.com>

re-add line

Signed-off-by: clux <sszynrae@gmail.com>

* clippy + fmt

Signed-off-by: clux <sszynrae@gmail.com>

---------

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: Dan Spencer <danrspen@gmail.com>
jmintb pushed a commit to jmintb/kube-rs that referenced this pull request Mar 9, 2023
* tracing output from kube-runtime

trying to hunt a potential bug

Signed-off-by: clux <sszynrae@gmail.com>

better tracing

Signed-off-by: clux <sszynrae@gmail.com>

ugh

Signed-off-by: clux <sszynrae@gmail.com>

lesssss output

Signed-off-by: clux <sszynrae@gmail.com>

remove backoff reset

Signed-off-by: clux <sszynrae@gmail.com>

better errors for watcher

Signed-off-by: clux <sszynrae@gmail.com>

re-add line

Signed-off-by: clux <sszynrae@gmail.com>

* clippy + fmt

Signed-off-by: clux <sszynrae@gmail.com>

---------

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent Controller error with partial watch permissions
3 participants