Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap validator for garde #1212

Merged
merged 8 commits into from
Apr 29, 2023
Merged

Swap validator for garde #1212

merged 8 commits into from
Apr 29, 2023

Commits on Apr 28, 2023

  1. Swap validator for garde 

    The validator crate used in the derive docs and in the crd example is no
longer actively maintained. It has been superseded by garde which offers
similar functionality.

This change replaces validator with garde in dev dependencies (and in
the crd_api example dependency). Although garde has the same derive
macro, its attribute differs from validator, and it additionally
requires fields to be explictly skipped from validation, and does not
offer a built-in way to validate required fields.

Changes have been made to the kube_derive crate's docs to both replace
existing mentions of validator, and inform on the caveats mentioned
above.

Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    6423114 View commit details
    Browse the repository at this point in the history

  2. Disable default features for garde 

    Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    5bc037d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Remove dev-dep in kube & kube-derive 

    Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    df951ac View commit details
    Browse the repository at this point in the history

  2. Change validate attr to schemars 

    Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    68518a9 View commit details
    Browse the repository at this point in the history

  3. Update kube-derive/src/lib.rs 

    Co-authored-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid @clux
    mateiidavid and clux committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    c705ebd View commit details
    Browse the repository at this point in the history

  4. Remove garde from kube examples 

    Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    994957f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'matei/swap-validation-lib' of github.com:mateiidavid/ku… 

    …be into matei/swap-validation-lib
    @mateiidavid
    mateiidavid committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    c44b9d2 View commit details
    Browse the repository at this point in the history

  6. Re-work headers and remove garde 

    Signed-off-by: Matei David <matei.david.35@gmail.com>
    @mateiidavid
    mateiidavid committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    b7275a4 View commit details
    Browse the repository at this point in the history