Store: Allow namespaced ObjectRefs to cluster-scoped objects #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kube-rs#293. This is a bit magical, but it's fairly common in K8s to allow reference fields (such as `OwnerReferences`) to refer to either cluster-scoped objects or namespaced resources in the same namespace. Code that converts those events into `ObjectRef`s generally won't know which of these cases is applicable, so this is the best we can do.
|
Ah, crap left comments on your commit rather than the pr. EDIT: anyway tests are good, just had a question about the last test. |
clux
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293.
This is a bit magical, but it's fairly common in K8s to allow reference
fields (such as
OwnerReferences) to refer to either cluster-scoped objectsor namespaced resources in the same namespace.
Code that converts those events into
ObjectRefs generally won't know which ofthese cases is applicable, so this is the best we can do.