Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding all library paths used by CustomResource derive #675

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 25, 2021

Building and expanding upon the #658 model.

@nightkr nightkr requested a review from clux October 25, 2021 07:30
@nightkr nightkr changed the title Allow overriding all library paths in derives Allow overriding all library paths used by CustomResource derive Oct 25, 2021
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
@nightkr nightkr force-pushed the feature/derive-override-lib-paths branch from ba09398 to f0ae673 Compare October 25, 2021 07:31
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and managing to do it all without making the code more complex 👍

@nightkr
Copy link
Member Author

nightkr commented Oct 25, 2021

@clux No idea why the integration tests started failing now, I haven't touched the k3d stuff there at all.

@clux
Copy link
Member

clux commented Oct 25, 2021

It looks like it was only cargo audit. Anyway everything's green now :-)

@nightkr
Copy link
Member Author

nightkr commented Oct 25, 2021

After the update I got an instant red on integration, but re-running it seems to have "fixed" it.

@nightkr nightkr merged commit 74872b3 into kube-rs:master Oct 25, 2021
@nightkr nightkr deleted the feature/derive-override-lib-paths branch October 25, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants