Fix event publishing for cluster scoped crds

[zhrebicek]

• There is no api for publishing cluster scoped events
• It default to default namespace
• Added ability to override namespace on Recorder::new

Motivation

We were getting 405 when trying to publish events for cluster scoped crds.

Solution

As there seems to be no endpoint for cluster scoped events.
I have added default namespace default for cluster scoped crds and I have added way to override it for all the cases.

I am not sure about the namespace_override but it seems good enough as is, maybe needs better comment/renaming.

cc: @teozkr

[clux]

There is no api for publishing cluster scoped events

ah thanks for this. TIL.

although, if this is true, then i'm thinking it might be better to fallback to Api::default_namespaced rather than force a string arg on everyone here 🤔

[zhrebicek]

although, if this is true, then i'm thinking it might be better to fallback to Api::default_namespaced rather than force a string arg on everyone here 🤔

I will fix the DCO thingy and try to add it there.

@clux should I also drop the namespace_override or would you like to keep it there?

[clux]

@clux should I also drop the namespace_override or would you like to keep it there?

yeah, i don't think we need an override for it. The default namespace is documented as:

The default namespace for objects with no other namespace

and events for a cluster scoped resource fits that definition pretty well.

i'll put in a suggestion.

[zhrebicek]

I see I have formatted this kube-runtime/src/watcher.rs by mistake, should I leave it as is ?

[clux]

I see I have formatted this kube-runtime/src/watcher.rs by mistake, should I leave it as is ?

The fmt job should not pass if you accidentally formatted something. Note that formatting is done with nightly; rustup update nightly then make fmt to fix it.

[clux]

minor comment nits, but LGTM

[codecov-commenter]

Codecov Report

Merging #847 (b2109e2) into master (0b5e803) will increase coverage by 0.13%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   70.31%   70.44%   +0.13%     
==========================================
  Files          59       59              
  Lines        4184     4203      +19     
==========================================
+ Hits         2942     2961      +19     
  Misses       1242     1242              

Impacted Files	Coverage Δ
kube-runtime/src/events.rs	94.44% <95.45%> (+1.99%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5e803...b2109e2. Read the comment docs.