ignore Retain field

[hougangliu]

in experiment.spec.trialTemplate and experiment.spec.metricsCollectorSpec, Retain filed is defined, which is used to delete worker job and metricCollecoter job when trial completed, but now we ignore the field when create new trial( Trial struct has no counterpart field of the two kind of Retain)

should we drop Retain in experiment and always delete worker job and metricCollecoter job when trial completed? or add two new field in trial.spec?

/cc @richardsliu @gaocegege @johnugeorge @YujiOshima which one do you prefer?

[gaocegege]

I have a question may not be related to the issue. How to support the case that the users want to create new trials for the completed experiment? Do we plan to support it? Ref #346

[johnugeorge]

We can add support for Retain in trial if needed. It should not be a big change.

[hougangliu]

I have a question may not be related to the issue. How to support the case that the users want to create new trials for the completed experiment? Do we plan to support it? Ref #346

We need discuss it more in next meeting or in #346. Anyway, I think the feature may be not included in release 0.6

[hougangliu]

/assign

[johnugeorge]

I have a question may not be related to the issue. How to support the case that the users want to create new trials for the completed experiment? Do we plan to support it? Ref #346

Other k8s objects follow the same convention right? eg: K8s Job

[hougangliu]

/close since #572 merged

[hougangliu]

/close

[k8s-ci-robot]

@hougangliu: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.