Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiment): Add more test cases #563

Merged
merged 3 commits into from
May 23, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 20, 2019

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@gaocegege
Copy link
Member Author

/hold cancel

/assign @johnugeorge @hougangliu

@gaocegege gaocegege changed the title WIP feat(experiment): Add more test cases feat(experiment): Add more test cases May 22, 2019
@hougangliu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member Author

/retest

4 similar comments
@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

/retest

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@hougangliu
Copy link
Member

/test kubeflow-katib-presubmit

@gaocegege
Copy link
Member Author

/hold

Test is failed bueause of deletion failures. I am trying to fix it.

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/hold cancel

/assign @hougangliu

@gaocegege
Copy link
Member Author

/cc @johnugeorge

@hougangliu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ef2ac5b into kubeflow:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants