Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Mark defaulted fields as optional #296

Conversation

fabriziopandini
Copy link
Contributor

This PR is a backport of kubernetes-sigs/cluster-api#2678

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from chuckha and ncdc July 2, 2020 18:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2020
Copy link
Contributor

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vincepri vincepri added this to the Next milestone Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@vincepri vincepri modified the milestones: Next, v0.1.x Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0bae6ec into kubernetes-retired:master Jul 2, 2020
@fabriziopandini fabriziopandini deleted the mark-defaulted-fields-as-optional branch July 7, 2020 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants