Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Add a shouldDelete method in the provisioner Qualifer interface #1046

Closed
wants to merge 1 commit into from

Conversation

jian-he
Copy link

@jian-he jian-he commented Nov 2, 2018

background describe in #1044

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jsafrane

If they are not already assigned, you can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jian-he
Copy link
Author

jian-he commented Nov 2, 2018

@wongma7 , mind helping taking a look ? thanks !

@jian-he
Copy link
Author

jian-he commented Nov 2, 2018

oh, just realized the lib is moved to https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner

close this and open a PR there..

@jian-he jian-he closed this Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants