Remove usage of 'echo' from log collector script #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the minimal image for the efs-plugin container, we do not include the echo script anymore. Therefore, I replaced its usage with ls, which we still include. (cherry picked from commit c3eeca7)
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the minimal image for the efs-plugin container, we do not include the echo script anymore. Therefore, I replaced its usage with ls, which we still include.
(cherry picked from commit c3eeca7)
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
When building the minimal image for the efs-plugin container, we do not include the echo executableanymore. Therefore, I replaced its usage with ls, which we still include.
What testing is done?
ran the log collector script against a driver Pod and ensured that it was successful.