-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'aws-efs-csi-driver' helm chart more configurable #1423 #1425
base: master
Are you sure you want to change the base?
Conversation
Welcome @msmohitkumar! |
Hi @msmohitkumar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: msmohitkumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @k8s-ci-robot @mortent @Atoms @steved |
@msmohitkumar: GitHub didn't allow me to assign the following users: steved. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @msmohitkumar, can you squash the commits to one, I can trigger the tests. |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
#1423
What testing is done?
"Rendered the Helm chart locally to verify whether the newly templatized values were successfully embedded into the Helm templates."