Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies #1440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

retornam
Copy link

Is this a bug fix or adding new feature?

This pr upgrades k8s dependencies to the latest 0.26.x version

What is this PR about? / Why do we need it?

The packages are out of date and this PR aims to bring the project up to date on the package verions

What testing is done?

Ran make test

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @retornam!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @retornam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: retornam
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 21, 2024
@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
@mskanth972
Copy link
Contributor

/test pull-aws-efs-csi-driver-e2e
Will run the test again to confirm that this is not a transient error due to announcement or any other changes in efs-utils.

@retornam
Copy link
Author

@mskanth972 I think the Dockerfileon master, starting from https://github.com/kubernetes-sigs/aws-efs-csi-driver/blame/29583689482f8677ab3c8efc04274a75b447e197/Dockerfile#L41 which is leading to the following
failures

45.03 error: Failed build dependencies:
45.03 	cargo is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64
45.03 	rust is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64

@mskanth972
Copy link
Contributor

Yeah, Will take a look.

@retornam
Copy link
Author

aws/efs-utils#237 should resolve the build failures after its merged.
I'll update the Dockerfile in this PR to add the make rpm-without-system-rust after

@retornam
Copy link
Author

@mskanth972 I think aws/efs-utils#237 is still vaild for cases where rust isn't installed with yum. I'll be grateful if you can help get that merged too. Thanks

@mskanth972
Copy link
Contributor

Hi @retornam thanks for the PR. Working on merging it.

Signed-off-by: retornam <retornam@users.noreply.github.com>
@retornam
Copy link
Author

@mskanth972 the other PR has been merged. I amended the commit to force re-build this PR. Can you please approve the workflow. Thanks

@k8s-ci-robot
Copy link
Contributor

@retornam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-e2e 2c8b38d link true /test pull-aws-efs-csi-driver-e2e
pull-aws-efs-csi-driver-external-test-eks 2c8b38d link true /test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@retornam
Copy link
Author

We need a new tag cut from master https://github.com/aws/efs-utils/tags after that is done, the line

git checkout $(git describe --tags $(git rev-list --tags --max-count=1)) && \

will work, else we'd have to modify it to use the master branch which isn't ideal.

@mskanth972
Copy link
Contributor

@retornam, we are working on it in making a new tag, it takes time as we need to cut a release for Amazon Linux, my teammate is working on it, will follow up with him to fastrack this.

@mskanth972
Copy link
Contributor

Hi @retornam, we are planning to release a feature request in this efs-utils release which is under testing phase and ECD for the new version of driver with your change will be 09/20 and for Addons will be 09/27.

@retornam
Copy link
Author

Hi @retornam, we are planning to release a feature request in this efs-utils release which is under testing phase and ECD for the new version of driver with your change will be 09/20 and for Addons will be 09/27.

Thank you. I will keep an eye out for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants