-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EKS kubelet-extra-args are not set when using managedmachinepool #2224
Comments
/area provider/eks |
@richardcase: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@richardcase the problem is that the machinepool is not converting template object into a concrete object. I sent a PR to CAPI, but it seems to do not work with concrete objects too. I will make a more deep investigation |
We are using the default launch template for eks, I am assuming this because we are not passing any launch template cluster-api-provider-aws/pkg/cloud/services/eks/nodegroup.go Lines 162 to 171 in b7294ce
There are any reasons for that? According to AWS Console the userdata is configured into launch template so we need to reconcile and pass a launch template in node group creation. @richardcase could you give me the basic paths about where start to fix this? I'm newbie into capa codebase. I am assuming the starting point is here
|
@felipeweb - there isn't a specific reason the launch template support isn't there for There is launch template support on the non-managed machine pool ( |
@felipeweb - also feel free to ping me on the slack channel if needed |
@richardcase I am working on it, I'll have a PR up today. We can gladly collaborate on it! @felipeweb |
Great @michaelbeaumont 👍 |
I'm not yet convinced If we let the The API to managed nodegroups provides a lot of the things that users would set through |
@michaelbeaumont @richardcase I understand the risks of supporting both formats, but even so, I think we must because the kubelet-extra-args can configure the taints in addition to the labels |
If we support both and there is overlap which would take precedence? (I need to have a look at the docs to give a better answer....will do that) |
Indeed, there are certain features that managed nodegroups don't yet natively support. This all make me wonder if it's worth supporting the structure of the managed nodegroup API in the What do we think about have some common part of Ultimately, what do we actually want these |
/milestone v0.7.x |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/lifecycle frozen |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
This is going to be fixed by #3094 |
/lifecycle frozen |
/remove-lifecycle frozen |
/milestone clear |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/kind bug
What steps did you take and what happened:
is using wrong userdata
What did you expect to happen:
Anything else you would like to add:
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: