-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MachinePool ASG instance refresh #3447
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hello @mweibel. This is still a desired thing, right? |
hi @Skarlso |
/triage accepted |
/help |
@sedefsavas: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I am also interested in this feature—we want to use our own tooling for managing instance rotation for existing ASGs, and Cluster API for managing the lifecycle of the ASG itself. |
/assign harveyxia |
/kind feature
Describe the solution you'd like
I'd like the ability to disable automatic instance refresh on a machinepool. Currently when one e.g. changes the AMI of a AWSMachinePool, an instance refresh is automatically started:
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/exp/controllers/awsmachinepool_controller.go#L480
Anything else you would like to add:
We have long running jobs on windows machines (boot up time takes a while and is expensive due to windows licensing). Ideally updating an AMI would not automatically refresh the instances but instead new instances come up with the new AMI while old instances are left as-is. In our use case they get shutdown after the job anyway, so with time a refresh is done without interrupting workloads.
I'd be happy to collaborate on a PR for this. I'm not 100% which approach to take - there are
RefreshPreferences
with aStrategy
(which currently only allowsRolling
):cluster-api-provider-aws/exp/api/v1beta1/awsmachinepool_types.go
Line 97 in e53fce7
I could extend this to e.g. allow
Disable
as the Strategy, but then it wouldn't map 1:1 to the ASG refresh properties so I'm not sure if this is the best approach.Environment:
kubectl version
): 1.23/etc/os-release
): windows/linux hybridThe text was updated successfully, but these errors were encountered: