Ability to define disk type in AWSManagedMachinePool

[phenixblue]

/kind feature

Describe the solution you'd like

Would like a filed added to allow for defining the disk type (e.g. gp2, io1, etc...) within the AWSManagedMachinePool spec.

Anything else you would like to add:

Today the spec only allows for specifying disk size, but maybe something similar to the volume type in the AWSMachineSpec

Environment:

• Cluster-api-provider-aws version: v1.5.0
• Kubernetes version: (use kubectl version): v1.22.10-eks
• OS (e.g. from /etc/os-release): Bottlerocket OS 1.9.1

[k8s-ci-robot]

@phenixblue: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[luthermonson]

just because i looked into this for like 10min ill leave some notes.

in the go aws sdk for eks there is CreateNodegroupInput which has no support for volume types or anything that looks like the volume mapping you can do in ec2.

DiskType says this:

// The root device disk size (in GiB) for your node group instances. The default
// disk size is 20 GiB. If you specify launchTemplate, then don't specify diskSize,
// or the node group deployment will fail. For more information about using
// launch templates with Amazon EKS, see Launch template support (https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html)
// in the Amazon EKS User Guide.

It's possible we need to implement CreateNodegroupInput.LaunchTemplate? The way eksctl got around this is by taking params and auto generating a launch config and assigning it on node group creation so perhaps CAPA should do the same thing. At bare minimum a user should be able to pass one in and use it.

[richardcase]

With #3094 (not released yet) this is possible via the launch template.

[richardcase]

As this is probably handled:

/priority awaiting-more-evidence

[richardcase]

/triage needs-information

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.