Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC_WORKLOAD variable is missing in e2e conf to support gc test cases #3998

Closed
wyike opened this issue Jan 20, 2023 · 4 comments · Fixed by #3999
Closed

GC_WORKLOAD variable is missing in e2e conf to support gc test cases #3998

wyike opened this issue Jan 20, 2023 · 4 comments · Fixed by #3999
Assignees
@wyike
Labels
kind/backport Issues or PRs requiring backports kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@wyike
Copy link
Contributor

wyike commented Jan 20, 2023 •
edited
Loading

/kind bug

What steps did you take and what happened:
gc testcases will apply some workloads for the testing. It will read the yaml from GC_WORKLOAD variable. We should provide the variables in e2e conf, otherwise the testcases would fail with exception.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2023
@wyike
Copy link
Contributor Author

wyike commented Jan 20, 2023

/assign

@dlipovetsky
Copy link
Contributor

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jan 23, 2023
@dlipovetsky
Copy link
Contributor

Should also go to release-1.5 branch.

/kind backport

@k8s-ci-robot k8s-ci-robot added the kind/backport Issues or PRs requiring backports label Jan 23, 2023
@wyike wyike mentioned this issue Jan 25, 2023
Merged
4 tasks
@wyike
Copy link
Contributor Author

wyike commented Jan 30, 2023

Haven't backport to release-1.5 branch. I will do in following up PR.

@wyike wyike mentioned this issue Mar 14, 2023
Merged
4 tasks
@wyike wyike mentioned this issue Mar 22, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyike wyike

Labels
kind/backport Issues or PRs requiring backports kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for gc related tests wyike/cluster-api-provider-aws
3 participants
@dlipovetsky @k8s-ci-robot @wyike