Fixes for gc related tests #3999

wyike · 2023-01-20T14:08:01Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3998

Special notes for your reviewer:

Checklist:

squashed commits
includes documentation
adds unit tests
adds or updates e2e tests

k8s-ci-robot · 2023-01-20T14:08:11Z

Hi @wyike. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wyike · 2023-01-20T14:20:11Z

test/e2e/suites/gc_managed/gc_managed_test.go

@@ -88,7 +88,7 @@ var _ = ginkgo.Describe("[managed] [gc] EKS Cluster external resource GC tests",
 		cp := ms.GetControlPlaneByName(ctx, ms.GetControlPlaneByNameInput{
 			Getter:    e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
 			Namespace: cluster.Spec.InfrastructureRef.Namespace,
-			Name:      cluster.Spec.InfrastructureRef.Name,
+			Name:      cluster.Spec.ControlPlaneRef.Name,


Control Plane Ref: API Version: controlplane.cluster.x-k8s.io/v1beta2 Kind: AWSManagedControlPlane Name: eks-extresgc-41ehz7-control-plane Namespace: eks-extresgc-3lx403 Infrastructure Ref: API Version: infrastructure.cluster.x-k8s.io/v1beta2 Kind: AWSManagedCluster Name: eks-extresgc-41ehz7 Namespace: eks-extresgc-3lx403

Get the controlplane name from ControlPlaneRef

richardcase · 2023-01-21T10:36:19Z

/ok-to-test

richardcase · 2023-01-24T17:40:00Z

@wyike - is there much more to do on this?

wyike · 2023-01-25T03:04:08Z

@wyike - is there much more to do on this?

Hi @richardcase, nothing more.

Just have the question regarding to remove AUTO_CONTROLLER_IDENTITY_CREATOR. I am not sure if I should remove it, I am considering the removal because gc_managed case will fail as default identity cannot be automatically created, but I see this option is set as False because of AWSClusterStaticIdentity case support 7f14d22. If leaving it as the default value, the true , would it affect AWSClusterStaticIdentity related cases? Or AUTO_CONTROLLER_IDENTITY_CREATOR=true can also be compatible with these cases? What do you think?

I read more on https://cluster-api-aws.sigs.k8s.io/topics/multitenancy.html and https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/docs/proposal/20200506-single-controller-multitenancy.md, it seems AUTO_CONTROLLER_IDENTITY_CREATOR=true won't affect AWSClusterStaticIdentity functionalities, right?

richardcase · 2023-01-26T10:47:42Z

it seems AUTO_CONTROLLER_IDENTITY_CREATOR=true won't affect AWSClusterStaticIdentity functionalities, right?

Thats correct @wyike 👍

richardcase · 2023-01-26T10:47:52Z

/test ?

k8s-ci-robot · 2023-01-26T10:47:54Z

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richardcase · 2023-01-26T10:48:23Z

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc

wyike · 2023-01-27T01:48:04Z

/retest

richardcase · 2023-01-30T09:26:52Z

/lgtm
/approve

k8s-ci-robot · 2023-01-30T09:26:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2023

k8s-ci-robot requested review from Ankitasw and AverageMarcus January 20, 2023 14:08

wyike force-pushed the gc_test branch from 1fb819c to 6db24c4 Compare January 20, 2023 14:18

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2023

wyike commented Jan 20, 2023

View reviewed changes

wyike marked this pull request as draft January 20, 2023 14:31

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2023

wyike marked this pull request as ready for review January 25, 2023 10:04

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023

k8s-ci-robot requested a review from dlipovetsky January 25, 2023 10:04

wyike force-pushed the gc_test branch from 6db24c4 to 196e0a9 Compare January 25, 2023 12:23

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2023

wyike force-pushed the gc_test branch from 196e0a9 to 9684470 Compare January 25, 2023 12:24

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2023

wyike force-pushed the gc_test branch from 9684470 to 787b8b1 Compare January 25, 2023 12:24

Fixes for gc related tests

331fe73

wyike force-pushed the gc_test branch from 787b8b1 to 331fe73 Compare January 25, 2023 12:26

k8s-ci-robot assigned richardcase Jan 30, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023

k8s-ci-robot merged commit 4140e60 into kubernetes-sigs:main Jan 30, 2023

wyike mentioned this pull request Mar 14, 2023

Fixes for gc related tests #4142

Merged

4 tasks

wyike mentioned this pull request Mar 22, 2023

REQUEST: New membership for @wyike kubernetes/org#4108

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for gc related tests #3999

Fixes for gc related tests #3999

wyike commented Jan 20, 2023 •

edited

Loading

k8s-ci-robot commented Jan 20, 2023

wyike Jan 20, 2023

richardcase commented Jan 21, 2023

richardcase commented Jan 24, 2023

wyike commented Jan 25, 2023 •

edited

Loading

richardcase commented Jan 26, 2023

richardcase commented Jan 26, 2023

k8s-ci-robot commented Jan 26, 2023

richardcase commented Jan 26, 2023

wyike commented Jan 27, 2023

richardcase commented Jan 30, 2023

k8s-ci-robot commented Jan 30, 2023

Fixes for gc related tests #3999

Fixes for gc related tests #3999

Conversation

wyike commented Jan 20, 2023 • edited Loading

k8s-ci-robot commented Jan 20, 2023

wyike Jan 20, 2023

Choose a reason for hiding this comment

richardcase commented Jan 21, 2023

richardcase commented Jan 24, 2023

wyike commented Jan 25, 2023 • edited Loading

richardcase commented Jan 26, 2023

richardcase commented Jan 26, 2023

k8s-ci-robot commented Jan 26, 2023

richardcase commented Jan 26, 2023

wyike commented Jan 27, 2023

richardcase commented Jan 30, 2023

k8s-ci-robot commented Jan 30, 2023

wyike commented Jan 20, 2023 •

edited

Loading

wyike commented Jan 25, 2023 •

edited

Loading