[backport 0.7] Remove os.Exit calls from TestMain

[jonathanbeber]

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

As described in go#34129, os.Exit() in the way we have in multiple
tests in this project make panics to fail silently. That was first
described in #3032.

Since go 1.15 the os.Exit(code) calls are not required, therefore,
let's make panics visible and just run m.Run().

Which issue(s) this PR fixes:
Fixes #3032

Special notes for your reviewer:

Checklist:

• squashed commits

Release note:

Refactor TestMain functions across the project to stop using os.Exit swallowing errors

[k8s-ci-robot]

@jonathanbeber: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @jonathanbeber. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

/ok-to-test

[jonathanbeber]

part of #3038

[jonathanbeber]

we need #3043 to fix tests.

[jonathanbeber]

This one will consume any panic, can confirm by adding a panic in any of the tests in the package.

~/Code/cluster-api-provider-aws(release-0.7)$ git diff
diff --git bootstrap/eks/api/v1alpha3/conversion_test.go bootstrap/eks/api/v1alpha3/conversion_test.go
index 9a3025df..b5b0449c 100644
--- bootstrap/eks/api/v1alpha3/conversion_test.go
+++ bootstrap/eks/api/v1alpha3/conversion_test.go
@@ -27,6 +27,7 @@ import (
 )
 
 func TestFuzzyConversion(t *testing.T) {
+       panic("test")
        g := NewWithT(t)
        scheme := runtime.NewScheme()
        g.Expect(AddToScheme(scheme)).To(Succeed())
~/Code/cluster-api-provider-aws(release-0.7)$ go test -timeout 30s sigs.k8s.io/cluster-api-provider-aws/api/v1alpha3
ok  	sigs.k8s.io/cluster-api-provider-aws/api/v1alpha3	0.021s

[jonathanbeber]

same for all other cases where we have defer func() { os.Exit(code) }() or similar.

[jonathanbeber]

This seems good to go

[sedefsavas]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment