normalize oidc configs to string values for comparison #3735
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
needs-priority
needs-ok-to-test
|
Hi @luthermonson. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
luthermonson
force-pushed
the
oidc-config
branch
from
fb8f095
to
f6daff6
Compare
|
oh... fixing the tests sorry about that |
luthermonson
force-pushed
the
oidc-config
branch
from
f6daff6
to
307db7b
Compare
k8s-ci-robot
added
size/L
|
pic of it working
|
luthermonson
force-pushed
the
oidc-config
branch
from
307db7b
to
2724f10
Compare
|
/test pull-cluster-api-provider-aws-test |
1 similar comment
|
/test pull-cluster-api-provider-aws-test |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-provider-aws-test |
luthermonson
force-pushed
the
oidc-config
branch
from
2724f10
to
2998f55
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
the idp code was also patching the control plane object every reconcile loop. added additional logic in this commit 5330024 to get out sooner if there are no procedures or if nothing changed on the idp status. |
|
the apidiff failure is a false positive, the OidcIdentityProviderConfig is an internal struct and never used in a crd and i'd like to propose we ignore it |
|
I concur. |
k8s-ci-robot
added
the
lgtm
| if err != nil { | ||
| s.scope.Error(err, "failed creating eks identity provider plan") | ||
| return fmt.Errorf("creating eks identity provider plan: %w", err) | ||
| } | ||
|
|
||
| // nothing will be done, we can leave | ||
| if len(procedures) == 0 { |
There was a problem hiding this comment.
This change here introduces a change in behaviour. Which might be fine, I'm just thinking aloud on this. Previously, we constantly reconciled the status even if it was the same. Which makes no sense. Why update it if the status is the same? I think this should be okay. Though I really would like to hear @dlipovetsky's opinion. :)
There was a problem hiding this comment.
ya i added this for exactly that reason... no point to update if everything is the same. i spent a lot of time in this code >.<
|
/retest |
|
@lmasiero this wont pass the apidiff check. it will need to get merged with it failed, it's not actually changing any real APIs it's just an internal struct used to reconcile the oidc config |
|
Yep we can ignore the apidiff failure. /test ? |
|
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
After review and e2e tests passing i think this is good to go. We will ignore the apidiff failure. So: /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/override pull-cluster-api-provider-aws-apidiff-main |
|
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-apidiff-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Normalizes OIDC configs into string values for easier comparison for reconciliation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3734
Special notes for your reviewer:
I have a test running with a debugger right now which will prove this fixed the issue so this is just ready for review and ill post screenshots of it being fixed when I have them.
Checklist: