Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint in /hack/tools and aws-iam-authenticator #3771

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Bump golangci-lint in /hack/tools and aws-iam-authenticator #3771

merged 1 commit into from
Oct 20, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Oct 12, 2022 •
edited
Loading

What type of PR is this?
/area release

What this PR does / why we need it:
This PR bumps :

  • aws-iam-authenticator to v0.5.10
  • golangci-lint to v1.50.0 in /hack/tools

This PR also fixes lint and generate file errors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2022
Skarlso
Skarlso reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@Ankitasw
Copy link
Member Author

@Skarlso next week onwards, i don't have to wait for approval post lgtm 😛

@Ankitasw
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 71d9064 into kubernetes-sigs:main Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Oct 20, 2022
@Ankitasw Ankitasw deleted the golangci-lint-bump branch October 20, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

@shivi28 shivi28 Awaiting requested review from shivi28

Assignees

@Skarlso Skarlso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @k8s-ci-robot @Skarlso