Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROPOSAL: Maintainers and reviewer changes #3775

Merged

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Oct 12, 2022

/hold

What type of PR is this?
/kind support

What this PR does / why we need it:

Make the following changes to maintainers & reviewers:

Let me or @sedefsavas know if you want to become a reviewer

This change will be on hold for approximately 1 week before its merged.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Oct 12, 2022

<3 <3 <3 <3

Massive thank you! :)

@richardcase richardcase changed the title WIP: Maintainers and reviewer changes WIP: PROPOSAL: Maintainers and reviewer changes Oct 12, 2022
@richardcase richardcase changed the title WIP: PROPOSAL: Maintainers and reviewer changes PROPOSAL: Maintainers and reviewer changes Oct 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2022
@richardcase
Copy link
Member Author

Lazy consensus until 19th October 2022

@Ankitasw
Copy link
Member

Very well deserved @Skarlso its always been a pleasure working with you.

@Skarlso
Copy link
Contributor

Skarlso commented Oct 13, 2022

Thank you, Ankita! I really appreciate your words. 😊😊😊❤️

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2022
@Ankitasw
Copy link
Member

Thank you for the proposal @richardcase. It has always been great working with CAPA and you folks 🙏

@richardcase
Copy link
Member Author

Just to echo what has been added in Slack for posterity against this change:

  • @Ankitasw has been a consistent contributor of changes and reviews over the last year and has shown great commitment to the project, personally as a maintainer it has made my life easier, so thank you Ankita 🙏
  • @Skarlso has made significant contributions in both reviews and new features (like ipv6) this year...thank you Gergely

You have both helped to push CAPA forward and i think as maintainers you will continue to make a significant impact and improvement on this project.

@sedefsavas
Copy link
Contributor

Thanks @Ankitasw and @Skarlso for all the commitment and great work to keep CAPA healthy!! 🙏

Very happy to see that CAPA is growing stronger with more maintainers.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2022
@Ankitasw
Copy link
Member

@richardcase Thanks a lot for updating the Contributing guidelines so precisely 👏 This looks quite neat and helpful 😄

@fabriziopandini
Copy link
Member

/lgtm
Congrats!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@richardcase
Copy link
Member Author

Lazy consensus is up so:

/unhold
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit c8c30fc into kubernetes-sigs:main Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Oct 19, 2022
@richardcase richardcase deleted the maintainers_reviewers_change branch October 19, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants