-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VPC CNI in managed control plane #3846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the conversion is right on this, but I could be wrong as I always get confused with the auto generated vs manual stuff.
I was expecting something that converted from the old .DisableVPCCNI
to the new .VpcCni.Disable
and vice-versa but I don't see that here. Am I missing something?
I have made conversions here |
/test pull-cluster-api-provider-aws-e2e-eks |
/override pull-cluster-api-provider-aws-apidiff-main |
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-apidiff-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e-eks |
e2e is passing. @Ankitasw @AverageMarcus - is there still a question outstanding on the conversion functions? |
I will run the tests again. |
/override pull-cluster-api-provider-aws-apidiff-main |
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-apidiff-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Until the e2e pass: /hold |
/approve @Ankitasw - looks good, thanks. If you unhold when the e2e finish and pass |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The test is flaky for external VPC so retriggered. |
/unhold |
What type of PR is this?
/kind refactor
What this PR does / why we need it:
Refactor the disableVPCCNI on the managed control plane inside VpcCni.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes Part of #2355
Fixes #3410
Special notes for your reviewer:
Checklist: