-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field #3847
Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field #3847
Conversation
/hold |
c0ef94a
to
8aaf4c0
Compare
/test pull-cluster-api-provider-aws-e2e |
2d45872
to
6e8515b
Compare
/test pull-cluster-api-provider-aws-e2e-clusterclass |
Looks like this has accidentally pulled in the changes made in #3835 also. Other than that looks good. |
Ah! I missed the hold. |
/test ? |
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e-eks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment on the roundtrip fuzzing test.
Once the ARN change merges lets rebase this so we get rid of the ARN changes.
6e8515b
to
b7cae76
Compare
/test pull-cluster-api-provider-aws-e2e-eks |
cc @richardcase @Skarlso @AverageMarcus for final review. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Skarlso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
This PR removes the failure domain field from
AWSMachineSpec
to respect CAPI's Machine/MD's failure domain field.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes Part of #2355
Special notes for your reviewer:
Checklist: