Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LoadBalancerReadyCondition on deletion #3871

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Update LoadBalancerReadyCondition on deletion #3871

merged 2 commits into from
Jan 9, 2023

Commits on Nov 22, 2022

  1. Update LoadBalancerReadyCondition on deletion 

    The LoadBalancerReadyCondition is sometimes explicitly patched and other
times it only updates the awsCluster object. Furthermore the condition
won't be patched by the patch helper in the AWSClusterReconciler,
because it's not in the `patch.WithOwnedConditions` list.
This change puts the condition in the list and also updates the
condition reason to `Deleted` when the LB is not found. Without setting
the condition in that case, the reconciler will set condition to
`Deleting` and it will never go back to `Deleted`.

Co-authored-by: Jose Armesto <github@armesto.net>
    @mnitchev @fiunchinho
    mnitchev and fiunchinho committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    430412c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Make gci linter happy

    @mnitchev
    mnitchev committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    cd7273f View commit details
    Browse the repository at this point in the history