Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add elasticfilesystem:TagResource action #4272

Merged
merged 1 commit into from
May 17, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 17, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

We're trying to migrate the periodic-cluster-api-provider-aws-e2e job from Prow build cluster running on GKE to Prow build cluster running on EKS. As part of that, we added a new job periodic-cluster-api-provider-aws-e2e-eks-canary. However, the job is consistently failing with:

capa-e2e: [It] [unmanaged] [functional] Workload cluster with EFS driver should pass dynamic provisioning test

After some investigation, we found out that efs-claim PVC is not getting provisioned and efs-csi-controller is logging to following error:

E0517 09:28:04.011078       1 driver.go:103] GRPC error: rpc error: code = Unauthenticated desc = Access Denied. Please ensure you have the right AWS permissions: Access denied

After some additional investigation, we found out that adding elasticfilesystem:TagResource action to the node policy solves the problem. We're not 100% sure why that solves the issue, but upstream EFS CSI driver added it relatively recently as well: kubernetes-sigs/aws-efs-csi-driver@cd41c38

We're also not 100% sure why we see this issue only in the new cluster, but we assume it might be related to the fact that we're using brand new boskos accounts, so maybe some account settings are different.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref kubernetes/k8s.io#5048

Checklist:

  • squashed commits
  • adds or updates e2e tests

Release note:

NONE

cc @dims @pkprzekwas

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 17, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2023
@xmudrii
Copy link
Member Author

xmudrii commented May 17, 2023

/assign @neolit123

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit d2b4f34 into kubernetes-sigs:main May 17, 2023
@xmudrii xmudrii deleted the efs-tagresource branch May 17, 2023 12:09
@Ankitasw
Copy link
Member

Ankitasw commented Jun 8, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@Ankitasw: new pull request created: #4324

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member

/cherry-pick release-2.0
/cherry-pick release-2.1

@k8s-infra-cherrypick-robot

@Ankitasw: new pull request created: #4335

In response to this:

/cherry-pick release-2.0
/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@Ankitasw: new pull request created: #4336

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants