-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set IMDSv2 as optional #4274
Set IMDSv2 as optional #4274
Conversation
97664e9
to
b888f63
Compare
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Skarlso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.1 |
@wyike: #4274 failed to apply on top of branch "release-2.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-2.1 |
@wyike: new pull request created: #4281 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
IMDSv2 enablement in #4037 is a breaking change. We need give customer time to migrate their applications.
This PR set IMDSv2 as optional as the default to not break existing customers. The instance will be the same instance metadata options as before after capa upgraded:
Customer can still customize instance metadata option themselves by configuring in the awsmachinetemplate/instanceMetadataOptions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4275
Special notes for your reviewer:
In future, if we want to enable IMDSv2 as default, we switch to below default values:
Checklist:
Release note: