-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the quickstart guide needs update for external cloud provider #4301
Conversation
/test pull-cluster-api-provider-aws-test |
Uh, I'm not sure about all of this. There is something not okay. There are templates in our e2e folder that use aws provider and still work. Yet this thing doesn't. I'm not sure what's up. |
@@ -0,0 +1,1078 @@ | |||
apiVersion: cluster.x-k8s.io/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not required in templates, as we are not running this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove. Thanks.
/test ? |
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just to test the EKS prow change: /test pull-cluster-api-provider-aws-e2e-eks-gc |
/test pull-cluster-api-provider-aws-e2e-eks-gc |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In-tree cloud provider support was removed in k8s v1.27. See the following: - kubernetes/kubernetes#118899 - kubernetes/kubernetes#115838 - kubernetes-sigs#4301 Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4299
Special notes for your reviewer:
Checklist:
Release note: