🌱 chore: add docker build to ci #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
changed the title
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
|
/retest |
k8s-ci-robot
added
the
lgtm
|
On further thought this needs to me changed /hold |
k8s-ci-robot
added
the
do-not-merge/hold
This script will be used by prow to test our docker builds that are an essential part of the release the process. We have encountered an issue where we aren't testing the different architectures. Signed-off-by: Richard Case <richard.case@suse.com>
richardcase
force-pushed
the
ci_docker
branch
from
9e4989a
to
7db9ab6
Compare
k8s-ci-robot
added
size/S
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This adds a new ci script that will be used by prow to test the docker builds of the controller-manager and clusterawsadm for all supported architectures so that we catch any issues with the builds. Currently we aren't covering all the architectures in the CI
There will be a new prow pre-submit that will call this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates #4835
Special notes for your reviewer:
Checklist:
Release note: