Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: bump rosa deps to fix int overflow on non-64bit arch #4836

Merged
merged 1 commit into from
Feb 29, 2024
Merged

🐛 fix: bump rosa deps to fix int overflow on non-64bit arch #4836

merged 1 commit into from
Feb 29, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Feb 29, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:
Bump rosa dep to fix overflow on non-64bit architectures (i.e. ARM)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fix #4835

Checklist:

  • squashed commits

Release note:

fix: bump rosa deps to fix int overflow on non-64bit arch

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 29, 2024
@damdo
Copy link
Member Author

damdo commented Feb 29, 2024

/retest

1 similar comment
@richardcase
Copy link
Member

/retest

@damdo
Copy link
Member Author

damdo commented Feb 29, 2024

/test pull-cluster-api-provider-aws-build-docker

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 25a0086 into kubernetes-sigs:main Feb 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release failed due to an issue with the ARM build
3 participants
@damdo @richardcase @k8s-ci-robot